Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating files in current directory during tests #2428

Open
stefan6419846 opened this issue Jan 29, 2024 · 0 comments
Open

Avoid creating files in current directory during tests #2428

stefan6419846 opened this issue Jan 29, 2024 · 0 comments
Labels
is-maintenance Anything that is just internal: Simplifying code, syntax changes, updating docs, speed improvements

Comments

@stefan6419846
Copy link
Collaborator

Running the tests will currently generate (and delete) temporary files inside the current working directory. This does not look right and should probably be replaced by appropriate temporary directories/files instead. Example test:

def test_get_images(src, expected_images):

Environment

Which environment were you using when you encountered the problem?

$ python -m platform
Linux-5.14.21-150400.24.100-default-x86_64-with-glibc2.31

$ python -c "import pypdf;print(pypdf._debug_versions)"
pypdf==4.0.1, crypt_provider=('local_crypt_fallback', '0.0.0'), PIL=10.1.0
@stefan6419846 stefan6419846 added the is-maintenance Anything that is just internal: Simplifying code, syntax changes, updating docs, speed improvements label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is-maintenance Anything that is just internal: Simplifying code, syntax changes, updating docs, speed improvements
Projects
None yet
Development

No branches or pull requests

1 participant