Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace black/pylint with ruff #1102

Open
qarmin opened this issue Jan 29, 2024 · 2 comments
Open

Replace black/pylint with ruff #1102

qarmin opened this issue Jan 29, 2024 · 2 comments

Comments

@qarmin
Copy link

qarmin commented Jan 29, 2024

Currently static checks takes 1 minute to apply - https://github.com/py-pdf/fpdf2/actions/runs/7676162269/job/20923341563

With ruff, this time should decrease to max ~10s without cache and 1s with cache

@andersonhc
Copy link
Collaborator

Hi @qarmin,

Thank you for the suggestion. I've been reading Ruff's documentation and so far ruff is not a drop-in replacement for pylint
https://docs.astral.sh/ruff/faq/#how-does-ruffs-linter-compare-to-pylint

I am running some tests, and maybe we can use ruff formatter replacing black and use the ruff linter alongside pylint.

@qarmin
Copy link
Author

qarmin commented Feb 5, 2024

Yes, ruff is not a 1:1 replacement for pylint.
Having switched from pylint in one project I've used, I didn't find any functionality in it that the lack of in ruff blocked me from switching.

Ruff + mypy would probably offer almost everything that pylint offers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants