Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: indirect_ref ➔ indirect_reference #1484

Merged
merged 3 commits into from Dec 10, 2022
Merged

Conversation

MartinThoma
Copy link
Member

@MartinThoma MartinThoma commented Dec 10, 2022

Small cleanup after #1467

See #1187

@MartinThoma MartinThoma changed the title Indirect reference MAINT: indirect_ref ➔ indirect_reference Dec 10, 2022
@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Base: 93.76% // Head: 94.12% // Increases project coverage by +0.35% 🎉

Coverage data is based on head (b7f4968) compared to base (2577009).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1484      +/-   ##
==========================================
+ Coverage   93.76%   94.12%   +0.35%     
==========================================
  Files          30       30              
  Lines        5470     5447      -23     
  Branches     1048     1039       -9     
==========================================
- Hits         5129     5127       -2     
+ Misses        206      191      -15     
+ Partials      135      129       -6     
Impacted Files Coverage Δ
PyPDF2/_page.py 91.95% <100.00%> (+0.02%) ⬆️
PyPDF2/_reader.py 90.30% <100.00%> (ø)
PyPDF2/_writer.py 89.41% <100.00%> (+1.99%) ⬆️
PyPDF2/_utils.py 99.47% <0.00%> (-0.02%) ⬇️
PyPDF2/_merger.py 93.20% <0.00%> (+2.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma merged commit a0abf1e into main Dec 10, 2022
@MartinThoma MartinThoma deleted the indirect-reference branch December 10, 2022 15:25
MartinThoma added a commit that referenced this pull request Dec 10, 2022
Documentation (DOC)
-  Deduplicate extract_text docstring (#1485)
-  How to cite PyPDF2 (#1476)

Maintenance (MAINT)
  Consistency changes:
  -  indirect_ref/ido ➔ indirect_reference, dest➔ page_destination (#1467)
  -  owner_pwd/user_pwd ➔ owner_password/user_password (#1483)
  -  position ➜ page_number in Merger.merge (#1482)
  -  indirect_ref ➜ indirect_reference (#1484)

[Full Changelog](2.12.0...2.12.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant