(maint) Use same prioritizer throughout catalog #2739
Merged
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under normal system runs, there wasn't any problem with the prioritizer being used, since the Puppet::Resource::Catalog created it and passed to all of the correct places. However, the testing methods in PuppetSpec::Compiler ended up lying to the user about the prioritizer that could be used. The prioritizer that was passed in was not the one actually used by the catalog for constructing the relationship graph. This was because the Puppet::Parser::Catalog used the one it had internally. The answer is to have the Puppet::Parser::Catalog act as one possible factory of prioritizers, and pass the prioritizer around as it needs it. This allows the tests to then pass in the correct prioritizer and use it consistently throughout.
|
CLA signed by all contributors. |
jpartlow
added a commit
that referenced
this pull request
Jun 5, 2014
…-to-be-used-in-tests (maint) Use same prioritizer throughout catalog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under normal system runs, there wasn't any problem with the prioritizer being
used, since the Puppet::Resource::Catalog created it and passed to all of the
correct places. However, the testing methods in PuppetSpec::Compiler ended up
lying to the user about the prioritizer that could be used. The prioritizer
that was passed in was not the one actually used by the catalog for
constructing the relationship graph. This was because the
Puppet::Parser::Catalog used the one it had internally. The answer is to have
the Puppet::Parser::Catalog act as one possible factory of prioritizers, and
pass the prioritizer around as it needs it. This allows the tests to then
pass in the correct prioritizer and use it consistently throughout.