(HI-239) Cherry pick speedup from master (from #22142) #191
+49
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, hiera would look up the 'datadir' from config inside the loop where it looks inside datafiles. This caused substantial slowdowns on sites with deep hierarchies. This commit moves the datadir lookup to be outside the the datasource-search loop and caused substantial speedups. (Timings are in the original ticket). This patch was written by Sean Millichamp; I just rebased it onto the current state of Hiera and submitted it on his behalf.
The patch to reduce the work done when traversing the hierarchy duplicated the datafile() method from Backend. This removes the duplicate code from the yaml backend and creates a new method on Backend to get just the files associated with the hierarchy.
|
CLA signed by all contributors. |
kylog
pushed a commit
that referenced
this pull request
May 19, 2014
…m-master (HI-239) Cherry pick speedup from master (from #22142)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.