From 2d09621de7f1ce56a16be5c051c31aa83339fec1 Mon Sep 17 00:00:00 2001 From: Joel Einbinder Date: Mon, 4 Mar 2019 16:56:42 -0800 Subject: [PATCH 1/2] test: disable flaky cookies test --- test/launcher.spec.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/launcher.spec.js b/test/launcher.spec.js index 953fce52572e8..c3766e0f5f75f 100644 --- a/test/launcher.spec.js +++ b/test/launcher.spec.js @@ -151,7 +151,8 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions, p // This might throw. See https://github.com/GoogleChrome/puppeteer/issues/2778 await rmAsync(userDataDir).catch(e => {}); }); - it('userDataDir option should restore cookies', async({server}) => { + // This mysteriously fails on Windows on AppVeyor. See https://github.com/GoogleChrome/puppeteer/issues/4111 + xit('userDataDir option should restore cookies', async ({server}) => { const userDataDir = await mkdtempAsync(TMP_FOLDER); const options = Object.assign({userDataDir}, defaultBrowserOptions); const browser = await puppeteer.launch(options); From 625294b27a8cf7c559ce163a84d375486d191ee5 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Mon, 4 Mar 2019 17:08:56 -0800 Subject: [PATCH 2/2] Update launcher.spec.js --- test/launcher.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/launcher.spec.js b/test/launcher.spec.js index c3766e0f5f75f..ff0d2aa986106 100644 --- a/test/launcher.spec.js +++ b/test/launcher.spec.js @@ -152,7 +152,7 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions, p await rmAsync(userDataDir).catch(e => {}); }); // This mysteriously fails on Windows on AppVeyor. See https://github.com/GoogleChrome/puppeteer/issues/4111 - xit('userDataDir option should restore cookies', async ({server}) => { + xit('userDataDir option should restore cookies', async({server}) => { const userDataDir = await mkdtempAsync(TMP_FOLDER); const options = Object.assign({userDataDir}, defaultBrowserOptions); const browser = await puppeteer.launch(options);