fix: mimic rejection for PuppeteerUtil on early call #9589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
force-pushed
the
fix-puppeteer-util
branch
from
e97376e
to
fe8930c
Compare
OrKoN
reviewed
Jan 26, 2023
jrandolf
force-pushed
the
fix-puppeteer-util
branch
6 times, most recently
from
2360523
to
6401ca1
Compare
jrandolf
force-pushed
the
fix-puppeteer-util
branch
from
6401ca1
to
868d48c
Compare
OrKoN
approved these changes
Jan 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rejects the PuppeteerUtil promise to mimic the behavior of when PuppeteerUtil cannot be evaluated due to navigation.
This also fixes a problem where the timeout would clear on navigation.