fix: use LazyArg for puppeteer utilities #9575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Jan 25, 2023
jrandolf
changed the title
clearContext only on resolution
jrandolf
force-pushed
the
fix/1
branch
4 times, most recently
from
d38c511
to
df4cc57
Compare
OrKoN
changed the title
OrKoN
approved these changes
Jan 26, 2023
Closed
OrKoN
added a commit
that referenced
this pull request
Jan 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following edge case:
const oldPromise = world.puppeteerUtil.world.#puppeteerUtil === oldPromiseis not resolved.world.#puppeteerUtilis replaced (world.#puppeteerUtil !== oldPromise).oldPromisenever resolves.