Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't clean up previous browser versions #9568

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Jan 24, 2023

Since we moved to the central binaries cache it does not make sense to clean up old binaries automatically because multiple installations can use different versions. We expect the users to clean the cache from time to time until we offer a CLI for managing the browsers.

Closes #9533

@OrKoN OrKoN marked this pull request as ready for review January 24, 2023 08:19
Copy link
Collaborator

@Lightning00Blade Lightning00Blade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add a log for the number of revisions being stored. That way the user easily see how many revisions they have saved and act upon that if need be.

@OrKoN
Copy link
Collaborator Author

OrKoN commented Jan 24, 2023

@Lightning00Blade added a log message.

@OrKoN OrKoN changed the title fix: don't clean up older chromium versions fix: don't clean up older browser versions Jan 24, 2023
@OrKoN OrKoN changed the title fix: don't clean up older browser versions fix: don't clean up previous browser versions Jan 24, 2023
Since we moved to the central binaries cache it does
not make sense to clean up old binaries automatically
because multiple installations can use different versions.
We expect the users to clean the cache from time to time
until we offer a CLI for managing the browsers.

Closes #9533
@OrKoN OrKoN merged commit 344bc2a into main Jan 24, 2023
@OrKoN OrKoN deleted the orkon/version-cleanup branch January 24, 2023 16:28
This was referenced Jan 24, 2023
@q--
Copy link

q-- commented Jan 30, 2023

So I saw this in the release notes, and it is not clear to me whether this applies to all of puppeteer or only to puppeteer-core. (I'm using the former.)

Does the puppeteer package still clean up old Chromium versions, or do I have to start cleaning them up myself so my disk won't fill up with unused Chromium installations? And if it's the latter, is there any (official or recommended) way to automate it?

@jacobg
Copy link

jacobg commented Jan 30, 2023

I was having this error for revision 1069273, then bumped to puppeteer 19.6.2, deployed to Google Cloud Function, and the error went away. Then a little later I did another deployment for an unrelated reason, and the error came back again on a new revision 1083080.

So it doesn't seem that 19.6.2 fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error: Could not find Chromium (rev. 1069273)
5 participants