New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove oopif expectations and fix oopif flakiness #9375
Conversation
a863b4e
to
aad442c
Compare
@@ -262,9 +262,6 @@ export class CDPPage extends Page { | |||
|
|||
#onDetachedFromTarget = (target: Target) => { | |||
const sessionId = target._session()?.id(); | |||
|
|||
this.#frameManager.onDetachedFromTarget(target); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should now be redundant because we always get frameDetached
event.
@@ -2128,5 +2044,71 @@ | |||
"platforms": ["darwin", "linux", "win32"], | |||
"parameters": ["firefox"], | |||
"expectations": ["PASS", "FAIL"] | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some common failures that have been around for a while now.
"parameters": ["chrome", "headless"], | ||
"expectations": ["PASS", "FAIL"] | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BiDi expectation should always be last.
902543d
to
05c8295
Compare
05c8295
to
236ebb3
Compare
With M109 the flakiness should be reduced. Any present flakiness should be investigated. Drive-by: added a few flaky tests to expecations.
236ebb3
to
204457a
Compare
With M109 the flakiness should be reduced. Any present flakiness should be investigated.
Drive-by: a new debugging helper to debug on CI.