Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove oopif expectations and fix oopif flakiness #9375

Merged
merged 6 commits into from Dec 9, 2022

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Dec 7, 2022

With M109 the flakiness should be reduced. Any present flakiness should be investigated.

Drive-by: a new debugging helper to debug on CI.

@OrKoN OrKoN force-pushed the orkon/remove-oopif-expectations branch 19 times, most recently from a863b4e to aad442c Compare December 9, 2022 08:24
@@ -262,9 +262,6 @@ export class CDPPage extends Page {

#onDetachedFromTarget = (target: Target) => {
const sessionId = target._session()?.id();

this.#frameManager.onDetachedFromTarget(target);
Copy link
Collaborator Author

@OrKoN OrKoN Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should now be redundant because we always get frameDetached event.

@OrKoN OrKoN marked this pull request as ready for review December 9, 2022 08:54
@@ -2128,5 +2044,71 @@
"platforms": ["darwin", "linux", "win32"],
"parameters": ["firefox"],
"expectations": ["PASS", "FAIL"]
},
{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some common failures that have been around for a while now.

"parameters": ["chrome", "headless"],
"expectations": ["PASS", "FAIL"]
},
{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BiDi expectation should always be last.

@OrKoN OrKoN force-pushed the orkon/remove-oopif-expectations branch from 902543d to 05c8295 Compare December 9, 2022 09:17
@OrKoN OrKoN changed the title chore: remove oopif expectations fix: remove oopif expectations and fix oopif flakiness Dec 9, 2022
@OrKoN OrKoN enabled auto-merge (squash) December 9, 2022 09:20
@OrKoN OrKoN force-pushed the orkon/remove-oopif-expectations branch from 05c8295 to 236ebb3 Compare December 9, 2022 09:54
With M109 the flakiness should be reduced. Any present
flakiness should be investigated.

Drive-by: added a few flaky tests to expecations.
@OrKoN OrKoN force-pushed the orkon/remove-oopif-expectations branch from 236ebb3 to 204457a Compare December 9, 2022 10:51
@OrKoN OrKoN merged commit 810e0cd into main Dec 9, 2022
@OrKoN OrKoN deleted the orkon/remove-oopif-expectations branch December 9, 2022 11:36
@release-please release-please bot mentioned this pull request Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants