feat(puppeteer-core): keydown supports commands #9357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
changed the title
OrKoN
approved these changes
Dec 3, 2022
|
Thanks! |
Merged
OrKoN
pushed a commit
that referenced
this pull request
Dec 7, 2022
🤖 I have created a release *beep* *boop* --- <details><summary>puppeteer: 19.4.0</summary> ## [19.4.0](puppeteer-v19.3.0...puppeteer-v19.4.0) (2022-12-07) ### Features * **chromium:** roll to Chromium 109.0.5412.0 (r1069273) ([#9364](#9364)) ([1875da6](1875da6)), closes [#9233](#9233) ### Dependencies * The following workspace dependencies were updated * dependencies * puppeteer-core bumped from 19.3.0 to 19.4.0 </details> <details><summary>puppeteer-core: 19.4.0</summary> ## [19.4.0](puppeteer-core-v19.3.0...puppeteer-core-v19.4.0) (2022-12-07) ### Features * ability to send headers via ws connection to browser in node.js environment ([#9314](#9314)) ([937fffa](937fffa)), closes [#7218](#7218) * **chromium:** roll to Chromium 109.0.5412.0 (r1069273) ([#9364](#9364)) ([1875da6](1875da6)), closes [#9233](#9233) * **puppeteer-core:** keydown supports commands ([#9357](#9357)) ([b7ebc5d](b7ebc5d)) ### Bug Fixes * **puppeteer-core:** avoid type instantiation errors ([#9370](#9370)) ([17f31a9](17f31a9)), closes [#9369](#9369) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1313
What kind of change does this PR introduce?
Feature.
Did you add tests for your changes?
Yes.
If relevant, did you update the documentation?
Yes.
Summary
Supports keyboard shotcuts on MacOS. See Chrome Devtools Protocol document: https://chromedevtools.github.io/devtools-protocol/tot/Input/#method-dispatchKeyEvent.