chore(ng-schematics): Spawn server when running ng e2e
#9306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Nov 23, 2022
OrKoN
approved these changes
Nov 23, 2022
Lightning00Blade
changed the title
ng e2e
chore: Post Review fix chore(ng-schematics): Spawn own server chore: Spawn test server chore: Fix non-default installs
Co-authored-by: Alex Rudenko <OrKoN@users.noreply.github.com>
OrKoN
force-pushed
the
feat/ng-schematics-remove-server-need
branch
from
9e7fb7f
to
a284f82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Spawn own server when running
ng e2e. Give user option to not replaceng e2e.Did you add tests for your changes?
Yes.
If relevant, did you update the documentation?
Yes,
ng-schematicsREADME.md updated.Summary
When running
ng-schematics'sng e2ecommand spawns it's own server. This way we remove the need of developers to runng serverseparately thus increasing ease of use in development and CI.We want to support Protractor migration so we give the user the option to opt out of replacing
ng e2eso they can have a gradual migration.(Note: There may be issues with folder conflicts, to be address in a PR for adding better Migration support)
Does this PR introduce a breaking change?
Yes, as we don't check if required options are there before spawning the server.
Other information