feat(puppeteer-core): update Chrome launcher flags #9239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds: - `--disable-component-update` - `--disable-features=MediaRouter` - `--disable-features=OptimizationHints` and removes `--disable-features=AvoidUnnecessaryBeforeUnloadCheckSync`. See https://github.com/GoogleChrome/chrome-launcher/blob/main/docs/chrome-flags-for-tools.md
OrKoN
force-pushed
the
feat-update-chrome-flags
branch
from
e267108
to
4a0a40d
Compare
| '--enable-automation', | ||
| // TODO(sadym): remove '--enable-blink-features=IdleDetection' once | ||
| // IdleDetection is turned on by default. | ||
| '--enable-blink-features=IdleDetection', |
There was a problem hiding this comment.
@sadym-chromium Do we still need this?
Lightning00Blade
approved these changes
Nov 10, 2022
This was referenced Nov 11, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 23, 2022
Closed
Closed
Closed
Merged
OrKoN
pushed a commit
that referenced
this pull request
Nov 23, 2022
🤖 I have created a release *beep* *boop* --- <details><summary>ng-schematics: 0.1.0</summary> ## 0.1.0 (2022-11-23) ### Features * **ng-schematics:** Release @puppeteer/ng-schematics ([#9244](#9244)) ([be33929](be33929)) </details> <details><summary>puppeteer: 19.3.0</summary> ## [19.3.0](puppeteer-v19.2.2...puppeteer-v19.3.0) (2022-11-23) ### Miscellaneous Chores * **puppeteer:** Synchronize puppeteer versions ### Dependencies * The following workspace dependencies were updated * dependencies * puppeteer-core bumped from 19.2.2 to 19.3.0 </details> <details><summary>puppeteer-core: 19.3.0</summary> ## [19.3.0](puppeteer-core-v19.2.2...puppeteer-core-v19.3.0) (2022-11-23) ### Features * **puppeteer-core:** Infer element type from complex selector ([#9253](#9253)) ([bef1061](bef1061)) * **puppeteer-core:** update Chrome launcher flags ([#9239](#9239)) ([ae87bfc](ae87bfc)) ### Bug Fixes * remove boundary conditions for visibility ([#9249](#9249)) ([e003513](e003513)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
--disable-component-update--disable-features=MediaRouter--disable-features=OptimizationHintsand removes
--disable-features=AvoidUnnecessaryBeforeUnloadCheckSync.See https://github.com/GoogleChrome/chrome-launcher/blob/main/docs/chrome-flags-for-tools.md