-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: goto hangs on headless: false #9047
Comments
Does it fail navigating to any website or only http://localhost:5678/workflows/demo? Could you publish |
@OrKoN http://localhost:5678/workflows/demo is n8n https://github.com/n8n-io/n8n ( |
Unfortunately, I am not able to reproduce on Mac with either of the URLs. Could you try reproducing this with puppeteer@18.0.5? Also, could you run the script with the env var |
@OrKoN I have also tried it with puppeteer@18.0.5 and only then changed to 18.1.0 to exclude the possibility that the error is already fixed. Here is the debug log:
|
@lublak so it happens in 18.0.5 for you too? It looks like the browser does not respond to the |
@OrKoN I have made completely new clean installation of the modules with 18.0.5 and once 18.1.0 |
I am not sure: there are no more details in the log. But you can see that the Page.navigate command with "id":18 is sent and there should be a response with the same id. It looks like the navigation hangs on the browser side. |
It could be very well be some issue in the Windows binary. It would be good if you could try it on a different machine. I will find a Windows machine in the meantime. |
I have been running multiple instances of Puppeteer in that same version, on Windows x64. I do not believe it is due to the OS. Could it be related to the chromium version bundled? If you could also give us a little hint on what kind of page are you trying to load, maybe? Or more prolific logs? It seems the navigation is not being detected through page events, we need to take into consideration it could be from the browser but also the page being served. |
@pecampelo @OrKoN Sry I was the last few days very under stress because of emergency work. I have now also started the bundled chrome manually. Chromium Version: I have already sent the log. What exactly would you like? I will try again today on my private computer the problem is on this computer. |
I have example of phishing site where it also hangs (even with headless), but i cannot share it. It has no protection from bots, just redirects to dead site and then puppeteer hangs in navigation indefinitely. One speciality is that it uses responses that are just <script> or without surrounding tags. On Puppeteer 10.2 with chromium, it works properly. It stops after being navigated to chrome-error://chromewebdata/ from page.on('framenavigated',... Problem is probably in waiting logic, because if I use Page.navigate and then wait for fixed amount , then chrome does not hang. I keep on debugging. If there is some good way how to debug this i would appreciate an advice. |
@miro-balaz it'd be great if you could create a minimal page (that does the same kind of navigations/causes same errors) that demonstrates the problem |
@pecampelo Yes, I am still trying to find out if I can create a simple example. Problem is that it works on my private computer at home without problems. Only in the company something blocks there. |
@OrKoN That would be hard, it has to be server. I have found that problem is in waiting for resposne that does not arive, and that wait is without timeout. see #onRequest in lifecycleWatcher |
are you using puppeteer 19.2.2? |
@lublak, I am thinking of suggesting you to create a dockerized application at your company that does the job, do you think that is more viable to do in your company network? That way we could replicate it, and even look at network ins and outs. What do you think of it, @OrKoN? |
@pecampelo I won't be trying to analyze an entire dockerized app (too time consuming) |
Now that I think of it, it does seem too time consuming and overtly bulky to actually provide some benefit... |
@pecampelo @OrKoN Hey who knows what's going crazy here. It's probably way too complicated to solve. But really great of you that you have given the effort up to here. |
@OrKoN After upgrading to 19.2.2 my problem is solved, thanks, i was on 19.2.0 before. |
@miro-balaz then it was a variation of #9175 @lublak I wonder if the fix also solves the issue you reported? |
@OrKoN unfortunately not. As soon as I go into the headless: false it hangs. |
Closing as there is no good way to test this. Please file a new issue if there is a reproducible example. |
Bug description
Steps to reproduce the problem:
(it works without headless: false)
Puppeteer version
18.1.0
Node.js version
v16.17.1
npm version
8.15.0
What operating system are you seeing the problem on?
Windows
Relevant log output
The text was updated successfully, but these errors were encountered: