fix!: remove root from WaitForSelectorOptions
#8848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
force-pushed
the
jrandolf/r2-2-6
branch
from
490ea15
to
13bfc0c
Compare
jrandolf
force-pushed
the
jrandolf/r2-2-6
branch
from
13bfc0c
to
e8e6fc8
Compare
jrandolf
force-pushed
the
jrandolf/r2-2-6
branch
from
e8e6fc8
to
aa4fa1e
Compare
OrKoN
reviewed
Aug 26, 2022
| | Parameter | Type | Description | | ||
| | --------- | -------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------ | | ||
| | selector | Selector | A [selector](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Selectors) of an element to wait for | | ||
| | options | Exclude<[WaitForSelectorOptions](./puppeteer.waitforselectoroptions.md), 'root'> | <i>(Optional)</i> Optional waiting parameters | |
There was a problem hiding this comment.
would it be still a breaking change? It looked like root was previously excluded from the API?
There was a problem hiding this comment.
Technically since root was exposed in Frame
OrKoN
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also moves some of the
waitForSelectorlogic intoQueryHandlerfor an upcoming PR related to removing DOM methods fromIsolatedWorlds