chore: infrastructure for injecting scripts into DOMWorlds #8801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Aug 17, 2022
jrandolf
force-pushed
the
refactor_wfs
branch
2 times, most recently
from
4401ca8
to
1f4dd8d
Compare
OrKoN
reviewed
Aug 17, 2022
jrandolf
force-pushed
the
refactor_wfs
branch
6 times, most recently
from
d7c45ae
to
e23cee4
Compare
OrKoN
changed the title
OrKoN
reviewed
Aug 17, 2022
OrKoN
reviewed
Aug 17, 2022
| const node = predicateQueryHandler | ||
| ? ((await predicateQueryHandler(root, selector)) as Element) | ||
| : root.querySelector(selector); | ||
| const node = (await predicateQueryHandler(root, selector)) as Element; |
There was a problem hiding this comment.
I think predicateQueryHandler might undefined? If we are sure it's always there, let's update times in makePredicateString to not allow empty predicate query handlers
OrKoN
reviewed
Aug 17, 2022
OrKoN
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
generatedfolder in favor of on-demand file generation. This includes improvements to the build system using a GNU Makefile-like scripts (job.ts) which drastically improves compilation speed.This PR also adds the
injectedfolder which contains scripts that will be executed in the puppeteer context. Within theinjectedfolder, somePollers which will be used in the upcoming refactoring of the wait tasks.