Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom sessions should not emit targetcreated events #8788

Merged
merged 1 commit into from Aug 16, 2022

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Aug 15, 2022

Closes #8787

@OrKoN OrKoN force-pushed the fix-custom-session branch 3 times, most recently from f904aeb to 830ffa3 Compare August 16, 2022 06:25
@OrKoN OrKoN requested a review from jrandolf August 16, 2022 07:32
src/common/Browser.ts Outdated Show resolved Hide resolved
src/common/Connection.ts Outdated Show resolved Hide resolved
@OrKoN OrKoN marked this pull request as ready for review August 16, 2022 08:14
@OrKoN OrKoN force-pushed the fix-custom-session branch 2 times, most recently from 3a32c8f to 175b278 Compare August 16, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: browserContext.on('targetcreated', t => t.createCDPSession()) goes haywire
2 participants