Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: targetFilter is never run when using puppeteer.launch #8772

Closed
adamraine opened this issue Aug 10, 2022 · 0 comments · Fixed by #8774 or #8769
Closed

[Bug]: targetFilter is never run when using puppeteer.launch #8772

adamraine opened this issue Aug 10, 2022 · 0 comments · Fixed by #8774 or #8769

Comments

@adamraine
Copy link
Contributor

Bug description

Steps to reproduce the problem:

import puppeteer from 'puppeteer';

const browser = await puppeteer.launch({
  targetFilter: () => console.log('###########');
})
const page = await browser.newPage();

await page.close();
await browser.close();

I expected to see some console messages when the callback function is executed but nothing gets printed. It looks like the callback never gets passed through to the browser object:

browser = await Browser._create(
this.product,
connection,
[],
ignoreHTTPSErrors,
defaultViewport,
runner.proc,
runner.close.bind(runner)
);

Puppeteer version

16.1.0

Node.js version

14.20.0

npm version

6.14.17

What operating system are you seeing the problem on?

macOS

Relevant log output

No response

@adamraine adamraine added the bug label Aug 10, 2022
OrKoN added a commit that referenced this issue Aug 11, 2022
Drive-by: adds Symbol.toStringTag to Target to simplify
debugging.

Closes #8772
OrKoN added a commit that referenced this issue Aug 11, 2022
Drive-by: adds Symbol.toStringTag to Target to simplify
debugging.

Closes #8772
OrKoN added a commit that referenced this issue Aug 11, 2022
Drive-by: adds Symbol.toStringTag to Target to simplify
debugging.

Closes #8772
OrKoN added a commit that referenced this issue Aug 11, 2022
Drive-by: adds Symbol.toStringTag to Target to simplify
debugging.

Closes #8772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants