Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: puppeteer.launch not resolved when timeout is 0 and headless: false #8763

Closed
cage1618 opened this issue Aug 10, 2022 · 0 comments · Fixed by #8765 or #8769
Closed

[Bug]: puppeteer.launch not resolved when timeout is 0 and headless: false #8763

cage1618 opened this issue Aug 10, 2022 · 0 comments · Fixed by #8765 or #8769
Assignees
@OrKoN
Labels
bug confirmed

Comments

@cage1618
Copy link

Bug description

Steps to reproduce the problem:

launch browser when set the timeout = 0 and headless = false , the promise not resolved forever.

const puppeteer = require('puppeteer');
(async () => {
  const browser = await puppeteer.launch({
    timeout: 0,
    headless: false
  })
})();

Puppeteer version

16.1.0

Node.js version

18.3.0

npm version

8.11.0

What operating system are you seeing the problem on?

macOS

Relevant log output

No response
@cage1618 cage1618 added the bug label Aug 10, 2022
@OrKoN OrKoN self-assigned this Aug 10, 2022
OrKoN added a commit that referenced this issue Aug 10, 2022
@OrKoN
fix: make sure there is a check for targets when timeout=0
0533ce3 
Previously, if timeout is falsy, the targets would only
be checked if a browser-level event fires which lead to
a race: if the events arrived before waiting for a target,
the promise would never resolve.

Fixes #8763
@OrKoN OrKoN mentioned this issue Aug 10, 2022
Merged
OrKoN added a commit that referenced this issue Aug 10, 2022
@OrKoN
fix: make sure there is a check for targets when timeout=0
d296bec 
Previously, if timeout is falsy, the targets would only
be checked if a browser-level event fires which lead to
a race: if the events arrived before waiting for a target,
the promise would never resolve.

Fixes #8763
OrKoN added a commit that referenced this issue Aug 10, 2022
@OrKoN
fix: make sure there is a check for targets when timeout=0 (#8765)
c23cdb7 
Previously, if timeout is falsy, the targets would only
be checked if a browser-level event fires which lead to
a race: if the events arrived before waiting for a target,
the promise would never resolve.

Fixes #8763
@release-please release-please bot mentioned this issue Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OrKoN OrKoN

Labels
bug confirmed
Projects
None yet
Milestone
No milestone
2 participants
@OrKoN @cage1618