Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use an xpath query handler #8730

Merged
merged 1 commit into from Aug 4, 2022
Merged

fix: use an xpath query handler #8730

merged 1 commit into from Aug 4, 2022

Conversation

jrandolf
Copy link
Contributor

@jrandolf jrandolf commented Aug 2, 2022

This PR replaces XPath handling in Puppeteer with the newer query handling API.

@jrandolf jrandolf requested a review from OrKoN August 2, 2022 14:36
OrKoN
OrKoN reviewed Aug 3, 2022
View reviewed changes
src/common/QueryHandler.ts Outdated Show resolved Hide resolved
OrKoN
OrKoN reviewed Aug 3, 2022
View reviewed changes
Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a fews test for using xpath selectors with the regular selector APIs, e.g., $, $$ and waitForSelector?

OrKoN
OrKoN reviewed Aug 3, 2022
View reviewed changes
src/common/ElementHandle.ts Outdated Show resolved Hide resolved
OrKoN
OrKoN reviewed Aug 3, 2022
View reviewed changes
src/common/QueryHandler.ts Outdated Show resolved Hide resolved
@jrandolf jrandolf force-pushed the query branch 10 times, most recently from ac6a9ec to 4f7abb1 Compare August 3, 2022 22:06
@jrandolf jrandolf changed the title feat: use an xpath query handler fix: use an xpath query handler Aug 3, 2022
OrKoN
OrKoN reviewed Aug 4, 2022
View reviewed changes
src/common/QueryHandler.ts Outdated Show resolved Hide resolved
OrKoN
OrKoN reviewed Aug 4, 2022
View reviewed changes
src/common/QueryHandler.ts Outdated Show resolved Hide resolved
@jrandolf jrandolf merged commit 5cf9b4d into main Aug 4, 2022
@jrandolf jrandolf deleted the query branch August 4, 2022 13:45
@release-please release-please bot mentioned this pull request Aug 4, 2022
Merged
@YusukeIwaki YusukeIwaki mentioned this pull request Sep 17, 2022
Merged
@jrandolf jrandolf added this to the Puppeteer Query Selectors milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrKoN OrKoN OrKoN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Puppeteer Query Selectors
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrandolf @OrKoN