feat: detect Firefox in connect() automatically #8718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
approved these changes
Aug 2, 2022
This was referenced Aug 2, 2022
jrandolf
pushed a commit
that referenced
this pull request
Aug 2, 2022
This PR implements automatic detection of the Firefox product when the `.connect()` method is used. This partially undoes the breaking change in #8520 but it's also a breaking change on its own since we don't accept an explicit product name anymore (it does not look like it was used anyway).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements automatic detection of the Firefox product when the
.connect()method is used. This partially undoes the breaking change in #8520 but it's also a breaking change on its own since we don't accept an explicit product name anymore (it does not look like it was used anyway).