Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test: request proxy should proxy requests when configured #8644

Closed
OrKoN opened this issue Jul 7, 2022 · 0 comments · Fixed by #8768 or #8769
Closed

Flaky test: request proxy should proxy requests when configured #8644

OrKoN opened this issue Jul 7, 2022 · 0 comments · Fixed by #8768 or #8769
Labels
flaky test

Comments

@OrKoN
Copy link
Collaborator

OrKoN commented Jul 7, 2022

Also, the test request proxy should respect proxy bypass list:

  1) request proxy
       should proxy requests when configured:
     TypeError: Cannot read properties of null (reading 'ok')
      at Context.<anonymous> (test/src/proxy.spec.ts:113:21)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
  2) request proxy
       should respect proxy bypass list:
     TypeError: Cannot read properties of null (reading 'ok')
      at Context.<anonymous> (test/src/proxy.spec.ts:134:21)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

The latest occurence is in npm run test:chrome:headless on Linux, Node 18: https://github.com/puppeteer/puppeteer/runs/7232316868?check_suite_focus=true
OrKoN added a commit that referenced this issue Aug 10, 2022
@OrKoN
fix: resolve navigation flakiness
ef9f141 
Closes #8644
@OrKoN OrKoN mentioned this issue Aug 10, 2022
Merged
OrKoN added a commit that referenced this issue Aug 10, 2022
@OrKoN
fix: resolve navigation flakiness
ec3658f 
Closes #8644
OrKoN added a commit that referenced this issue Aug 10, 2022
@OrKoN
fix: resolve navigation flakiness
64f0300 
Closes #8644
OrKoN added a commit that referenced this issue Aug 10, 2022
@OrKoN
fix: resolve navigation flakiness
6aae58b 
Closes #8644
OrKoN added a commit that referenced this issue Aug 10, 2022
@OrKoN
fix: resolve navigation flakiness
a009046 
Closes #8644
OrKoN added a commit that referenced this issue Aug 10, 2022
@OrKoN
fix: resolve navigation flakiness
3559483 
Closes #8644
OrKoN added a commit that referenced this issue Aug 10, 2022
@OrKoN
fix: resolve navigation flakiness
eade1ed 
Closes #8644
OrKoN added a commit that referenced this issue Aug 10, 2022
@OrKoN
fix: resolve navigation flakiness (#8768)
2580347 
Two main sources of flakiness addressed: 

1) we should dispose the lifecycle watcher after we waited for the navigation response (bad API? we need to refactor but I think it'd be valuable to stabilize tests first without too many changes).
2) we should wait for the navigation request's response if there is a navigation request in the watcher.

Closes #8644
@release-please release-please bot mentioned this issue Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky test
Projects
None yet
Milestone
No milestone
1 participant
@OrKoN