Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain useful TypeScript types no longer exposed since 15.2.0 #8639

Closed
niieani opened this issue Jul 6, 2022 · 1 comment · Fixed by #8642 or #8647
Closed

Certain useful TypeScript types no longer exposed since 15.2.0 #8639

niieani opened this issue Jul 6, 2022 · 1 comment · Fixed by #8642 or #8647
Assignees
Labels

Comments

@niieani
Copy link

niieani commented Jul 6, 2022

Affected version: 15.2.0+

Creating an issue by request of @jrandolf.

At least two issues were caused by #8584:

  • not possible to access the RemoteObject of a JSHandle anymore (details)
  • Protocol is longer re-exported, meaning the consumer needs to keep devtools-protocol version in sync with the one used by puppeteer, at least if they don't want to reach into a transitive dependency (i.e. undeclared in package.json).

Example where this is an issue: niieani/puppeteer-intercept-and-modify-requests#4 (files)

@OrKoN OrKoN added the bug label Jul 7, 2022
@OrKoN
Copy link
Collaborator

OrKoN commented Jul 7, 2022

I suggest we expose the remote object on JSHandle as an official documented API and make the protocol types available so that you don't need to install the devtools-protocol package yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants