fix: Clean up tmp profile dirs when browser is closed

[pablomatiasgomez]

What kind of change does this PR introduce?

Bugfix: Puppeteer is not deleting tmp profiles after browser is closed.

Did you add tests for your changes?

Yes, I actually first created the test to verify that it was actually broken the way I thought.

If relevant, did you update the documentation?

No, this is a small bugfix, but let me know if I should update anything.

Summary

Puppeteer has a feature in which if you don't specify a user data dir (--user-data-dir) it automatically creates one in a tmp folder, and then it's deleted when the browser is closed.
It seems that this feature got broken here, as it is now setting isTempUserDataDir to false in any case.

In my particular case, I instantiate Puppeteer multiple times, leading to an infinite number of dirs in the /tmp folder which were only deleted when I restarted the node.

ls -l /tmp/puppeteer_dev_chrome_profile-*  | wc -l
344

Does this PR introduce a breaking change?

No. (unless for any reason somebody is expecting for tmp profiles to be kept)

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[OrKoN]

Thanks for fixing this and for the test! I think it looks good and it only needs to skip this test on Firefox like the other tests.

[pablomatiasgomez]

@OrKoN thanks for reviewing! I just changed the test to to be chrome only. Let me know if it looks good