revert: do not use loaderId for lifecycle events #8369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
approved these changes
May 19, 2022
This reverts commit 7107d2d.
jrandolf
force-pushed
the
revert-8353-fix-lifecycle-event
branch
from
e36cea0
to
2846eba
Compare
|
Can we at the same time backout the disable patch for Firefox in CI as well? Or would this be in a separate PR? |
This will be in a separate PR. |
OrKoN
added a commit
that referenced
this pull request
May 25, 2022
OrKoN
added a commit
that referenced
this pull request
May 25, 2022
jrandolf
pushed a commit
that referenced
this pull request
May 25, 2022
OrKoN
added a commit
that referenced
this pull request
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8353 as it breaks Firefox integration.