Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: continue on error for Firefox tests #8368

Merged
merged 1 commit into from May 19, 2022
Merged

chore: continue on error for Firefox tests #8368

merged 1 commit into from May 19, 2022

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented May 19, 2022

Temporarily continue on test failures in Firefox until #8361 is fixed

@OrKoN OrKoN requested a review from jrandolf May 19, 2022 06:28
@OrKoN
Copy link
Collaborator Author

OrKoN commented May 19, 2022

cc @juliandescottes @whimboo

Copy link
Collaborator

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal but fine with me to get you unblocked. Hopefully we can get this fixed pretty soon.

@OrKoN OrKoN merged commit bfead97 into main May 19, 2022
@OrKoN OrKoN deleted the skip-ff-tests branch May 19, 2022 07:17
@whimboo
Copy link
Collaborator

whimboo commented May 19, 2022

@OrKoN can we get this change reverted as well now that the causing commit got backed out?

@OrKoN
Copy link
Collaborator Author

OrKoN commented May 19, 2022

I will revert this one once the other revert lands

OrKoN added a commit that referenced this pull request May 19, 2022
OrKoN added a commit that referenced this pull request May 19, 2022
OrKoN added a commit that referenced this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants