fix: do not use loaderId for lifecycle events #8353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
changed the title
OrKoN
force-pushed
the
fix-lifecycle-event
branch
from
dfa1b4a
to
122e0cb
Compare
jrandolf
approved these changes
May 17, 2022
jrandolf
suggested changes
May 17, 2022
|
There is no change in behaviour, it fixes the failing existing tests (see https://github.com/puppeteer/puppeteer/actions/runs/2330686327) |
jrandolf
approved these changes
May 17, 2022
OrKoN
force-pushed
the
fix-lifecycle-event
branch
from
122e0cb
to
91503ad
Compare
jrandolf
pushed a commit
that referenced
this pull request
May 19, 2022
This reverts commit 7107d2d.
OrKoN
added a commit
that referenced
this pull request
May 19, 2022
OrKoN
added a commit
that referenced
this pull request
May 25, 2022
OrKoN
added a commit
that referenced
this pull request
May 25, 2022
jrandolf
pushed a commit
that referenced
this pull request
May 25, 2022
OrKoN
added a commit
that referenced
this pull request
May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works around the upstream bug crbug.com/1325782. Previously Puppeteer relied on the presence of the loaderId to determine the kind of navigation and expected events. It does not look like there is a reason to do so: instead, we could see what events we get and proceed accordingly.