fix: only check loading iframe in lifecycling #8348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
requested changes
May 16, 2022
jrandolf
changed the title
OrKoN
reviewed
May 17, 2022
OrKoN
reviewed
May 17, 2022
OrKoN
reviewed
May 17, 2022
OrKoN
reviewed
May 17, 2022
OrKoN
reviewed
May 17, 2022
jrandolf
force-pushed
the
nav
branch
3 times, most recently
from
ebe37ec
to
cb08da0
Compare
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures lazy-loaded frames do not stall navigation of a frame by flagging frames that have not started loading.