Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove obsolete puppeteer-firefox package #8307

Merged
merged 2 commits into from May 5, 2022
Merged

chore: remove obsolete puppeteer-firefox package #8307

merged 2 commits into from May 5, 2022

Conversation

jrandolf
Copy link
Contributor

@jrandolf jrandolf commented May 3, 2022

No description provided.

@jrandolf jrandolf requested a review from OrKoN May 3, 2022 13:24
@jrandolf jrandolf enabled auto-merge (squash) May 3, 2022 13:25
@jrandolf jrandolf requested review from ergunsh and removed request for OrKoN May 3, 2022 13:25
Copy link
Collaborator

@ergunsh ergunsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though @OrKoN to approve :)

I also wonder, there is a package puppeteer-firefox and we've said that the package will remain available until the transition happens. So, is the transition already happened?

If so, would it make sense to update puppeteer-firefox package somehow to move the users from there to puppeteer itself; wdyt? AFAIU there are still quite some users of that package (13k weekly downloads)

@jrandolf jrandolf requested a review from OrKoN May 3, 2022 13:35
@OrKoN OrKoN requested a review from whimboo May 3, 2022 14:26
@OrKoN
Copy link
Collaborator

OrKoN commented May 3, 2022

Henrik, do you know if we are able to remove the source for the puppeteer-firefox package now?

@whimboo
Copy link
Collaborator

whimboo commented May 3, 2022

Henrik, do you know if we are able to remove the source for the puppeteer-firefox package now?

Nothing basically uses it for a while, right? Note that we still have Firefox Nightly support only. Maybe we can discuss that in the next upcoming Puppeteer/Firefox meeting? I'll add it to the agenda.

@whimboo whimboo changed the title chore: remove obsolete code chore: remove obsolete puppeteer-firefox package May 3, 2022
@OrKoN
Copy link
Collaborator

OrKoN commented May 4, 2022

I think it's not used anywhere. It will remain available at https://www.npmjs.com/package/puppeteer-firefox and there is already a deprecation notice that it is not maintained. I guess we can discuss it during the meeting but looks like the source code could be removed. In the worst case, we would need to recover the source code if we need to make an update to the package. Also, the overall status puppeteer-firefox seems to be an experimental prototype. So if you think we should discuss it in the meeting, that sounds good to me. Otherwise, let's just remove the code in this CL if you are not relying on it anywhere (we don't).

@whimboo
Copy link
Collaborator

whimboo commented May 5, 2022

@OrKoN the code in puppeteer-firefox is not ours. So it's nothing what we would need. I'm happy to see it removed if you think that we don't need to have a discussion. Maybe it could be kept in a specific branch for now and then removed from main?

@OrKoN
Copy link
Collaborator

OrKoN commented May 5, 2022

SGTM. I have created a branch called puppeteer-firefox to have to available there for easy access (although it's fairly easy to recover without the branch). I think we can land this now.

@jrandolf jrandolf merged commit b05ef09 into main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants