New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove obsolete puppeteer-firefox package #8307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though @OrKoN to approve :)
I also wonder, there is a package puppeteer-firefox
and we've said that the package will remain available until the transition happens. So, is the transition already happened?
If so, would it make sense to update puppeteer-firefox
package somehow to move the users from there to puppeteer
itself; wdyt? AFAIU there are still quite some users of that package (13k weekly downloads)
Henrik, do you know if we are able to remove the source for the puppeteer-firefox package now? |
Nothing basically uses it for a while, right? Note that we still have Firefox Nightly support only. Maybe we can discuss that in the next upcoming Puppeteer/Firefox meeting? I'll add it to the agenda. |
I think it's not used anywhere. It will remain available at https://www.npmjs.com/package/puppeteer-firefox and there is already a deprecation notice that it is not maintained. I guess we can discuss it during the meeting but looks like the source code could be removed. In the worst case, we would need to recover the source code if we need to make an update to the package. Also, the overall status puppeteer-firefox seems to be an experimental prototype. So if you think we should discuss it in the meeting, that sounds good to me. Otherwise, let's just remove the code in this CL if you are not relying on it anywhere (we don't). |
@OrKoN the code in |
SGTM. I have created a branch called |
No description provided.