Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable a failing Firefox test #8286

Merged
merged 1 commit into from Apr 27, 2022
Merged

test: disable a failing Firefox test #8286

merged 1 commit into from Apr 27, 2022

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Apr 27, 2022

No description provided.

@OrKoN
Copy link
Collaborator Author

OrKoN commented Apr 27, 2022

cc @whimboo

@OrKoN OrKoN requested a review from ergunsh April 27, 2022 15:27
@OrKoN OrKoN merged commit 912dfba into main Apr 27, 2022
@OrKoN OrKoN deleted the disable-ff-test branch April 27, 2022 15:34
@whimboo
Copy link
Collaborator

whimboo commented Apr 27, 2022

@OrKoN do you have some more details? How often is this test failing? Is it permanent or intermittent? And it seems to be MacOS only?

The failure is actually caused by a timeout:
https://github.com/puppeteer/puppeteer/runs/6189321000?check_suite_focus=true


  1) Launcher specs
       Puppeteer
         Puppeteer.launch
           should have custom URL when launching browser:
     Error: Timeout of 25000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/runner/work/puppeteer/puppeteer/test/launcher.spec.ts)
      at listOnTimeout (internal/timers.js:554:17)
      at processTimers (internal/timers.js:497:7)

Maybe it's related to my fix on bug https://bugzilla.mozilla.org/show_bug.cgi?id=1759169 and that we face a shutdown hang of Firefox.

@whimboo
Copy link
Collaborator

whimboo commented Apr 27, 2022

Actually lets move further discussion to issue #8283.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants