Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use different test names for browser specific default arguments tests in launcher.spec.ts #8250

Merged
merged 1 commit into from Apr 20, 2022

Conversation

whimboo
Copy link
Collaborator

@whimboo whimboo commented Apr 19, 2022

The changes as pushed on RP #8233 caused duplicated test names which makes it hard for our downstream sync of Puppeteer to maintain an expected results list in JSON by having test names as key.

As such I would suggest that we rename both tests and explicitly add the browser name in the test name.

@whimboo
Copy link
Collaborator Author

whimboo commented Apr 19, 2022

@OrKoN can you please review? Thanks

@whimboo whimboo requested a review from OrKoN April 19, 2022 15:22
@OrKoN
Copy link
Collaborator

OrKoN commented Apr 20, 2022

LGTM. We can land it after the current release is done!

@whimboo
Copy link
Collaborator Author

whimboo commented Apr 20, 2022

As it looks like the 13.6.0 release is already out. :)

@OrKoN OrKoN enabled auto-merge (squash) April 20, 2022 08:50
@OrKoN OrKoN merged commit 04f7659 into puppeteer:main Apr 20, 2022
@whimboo
Copy link
Collaborator Author

whimboo commented Apr 20, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants