replace if/else inside the test case by itChromeOnly and itFirefoxOnly #8095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is a refactor that aims to improve a bit how the test is structured? Instead of having a if/else inside the test case, I am using the utility function itChromeOnly and itFirefoxOnly
Did you add tests for your changes?
I ran the test suite in my local
If relevant, did you update the documentation?
Not sure if this requires doc update?
Summary
The motivation is just for the test structure in a sense? I saw that this utility function was added but is not used on this specific case. Maybe it is a good idea to use the helper. If it is, I can try to inspect the code and replace in other places.
Does this PR introduce a breaking change?
As far as I can see no
Other information