Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace if/else inside the test case by itChromeOnly and itFirefoxOnly #8095

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

marabesi
Copy link
Contributor

@marabesi marabesi commented Mar 3, 2022

What kind of change does this PR introduce?

This is a refactor that aims to improve a bit how the test is structured? Instead of having a if/else inside the test case, I am using the utility function itChromeOnly and itFirefoxOnly

Did you add tests for your changes?

I ran the test suite in my local

If relevant, did you update the documentation?

Not sure if this requires doc update?

Summary

The motivation is just for the test structure in a sense? I saw that this utility function was added but is not used on this specific case. Maybe it is a good idea to use the helper. If it is, I can try to inspect the code and replace in other places.

Does this PR introduce a breaking change?

As far as I can see no

Other information

@google-cla
Copy link

google-cla bot commented Mar 3, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@OrKoN OrKoN merged commit 9ca57f1 into puppeteer:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants