Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant await while fetching target #7351

Merged
merged 1 commit into from Jun 23, 2021

Conversation

yashLadha
Copy link
Contributor

Removed the redundant await from the block while fetching the target.
Since the value of map is of instance Target which itself is not an
async resource.

Removed the redundant await from the block while fetching the target.
Since the value of map is of instance `Target` which itself is not an
async resource.
@google-cla google-cla bot added the cla: yes label Jun 23, 2021
@mathiasbynens
Copy link
Member

There’s some async stuff happening in the constructor, but nothing that await has any effect on AFAICT. There’s also no then method on the Target class (which would implicitly be called by the await). So it does seem like this await is indeed redundant. Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants