New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added download location to the FAQ #7339
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks! |
* fix: modified comment for method product, platform and newPage * fix: added comment for browsercontext, StartCSSCoverage, StartJSCoverage * fix: corrected comments for JSONValue, asElement, evaluateHandle * fix: corrected comments for JSONValue, asElement, evaluateHandle * fix: added comments for some of the method * fix: added proper comments * fix: added comment for some methods in page.ts * fix: rectified the comments * fix: changed some of the comments * fix: added comments for 3 more methods of class page * fix: added comments for 3 more methods of class page * fix: added comments for 5 more methods in class page * fix: removed the extra whitespace * fix: added comments for 5 more method in page class * fix: added comments for 5 more methods in class page * fix: commented 12 more methods in class Page * fix: commented 12 methods in class Page * fix: commented 12 more methods in class Page * fix: commented 12 more methods in class Page * chore: fix typo in connection.spec.js (#7326) recieved -> received * chore: synchronize Bug 1710839: update comment about firefox preference remote.enabled (#7324) * fix: added comments for methods in class page * docs: add download location to the FAQ (#7339) Co-authored-by: Mathias Bynens <mathias@qiwi.be> * fix: added comments * fix: comments added * feat: add page.emulateCPUThrottling (#7343) * fix: added comments Co-authored-by: Jack Franklin <jacktfranklin@chromium.org> Co-authored-by: Ikko Ashimine <eltociear@gmail.com> Co-authored-by: Julian Descottes <julian.descottes@gmail.com> Co-authored-by: Diego Fernandez <dfernandez79@users.noreply.github.com> Co-authored-by: Mathias Bynens <mathias@qiwi.be> Co-authored-by: Jan Scheffler <janscheffler@chromium.org>
This PR is related to #6833
It adds extra instructions on how to cache the Chromium download outside
node_modules
.