Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo in connection.spec.js #7326

Merged
merged 1 commit into from Jun 14, 2021

Conversation

eltociear
Copy link
Contributor

recieved -> received

@google-cla google-cla bot added the cla: yes label Jun 12, 2021
@mathiasbynens mathiasbynens merged commit f984beb into puppeteer:main Jun 14, 2021
tasneemkoushar added a commit that referenced this pull request Jun 20, 2021
* fix: modified comment for method product, platform and newPage

* fix: added comment for browsercontext, StartCSSCoverage, StartJSCoverage

* fix: corrected comments for JSONValue, asElement, evaluateHandle

* fix: corrected comments for JSONValue, asElement, evaluateHandle

* fix: added comments for some of the method

* fix: added proper comments

* fix: added comment for some methods in page.ts

* fix: rectified the comments

* fix: changed some of the comments

* fix: added comments for 3 more methods of class page

* fix: added comments for 3 more methods of class page

* fix: added comments for 5 more methods in class page

* fix: removed the extra whitespace

* fix: added comments for 5 more method in page class

* fix: added comments for 5 more methods in class page

* fix: commented 12 more methods in class Page

* fix: commented 12 methods in class Page

* fix: commented 12 more methods in class Page

* fix: commented 12 more methods in class Page

* chore: fix typo in connection.spec.js (#7326)

recieved -> received

* chore: synchronize Bug 1710839: update comment about firefox preference remote.enabled (#7324)

* fix: added comments for methods in class page

Co-authored-by: Jack Franklin <jacktfranklin@chromium.org>
Co-authored-by: Ikko Ashimine <eltociear@gmail.com>
Co-authored-by: Julian Descottes <julian.descottes@gmail.com>
tasneemkoushar added a commit that referenced this pull request Jun 22, 2021
* fix: modified comment for method product, platform and newPage

* fix: added comment for browsercontext, StartCSSCoverage, StartJSCoverage

* fix: corrected comments for JSONValue, asElement, evaluateHandle

* fix: corrected comments for JSONValue, asElement, evaluateHandle

* fix: added comments for some of the method

* fix: added proper comments

* fix: added comment for some methods in page.ts

* fix: rectified the comments

* fix: changed some of the comments

* fix: added comments for 3 more methods of class page

* fix: added comments for 3 more methods of class page

* fix: added comments for 5 more methods in class page

* fix: removed the extra whitespace

* fix: added comments for 5 more method in page class

* fix: added comments for 5 more methods in class page

* fix: commented 12 more methods in class Page

* fix: commented 12 methods in class Page

* fix: commented 12 more methods in class Page

* fix: commented 12 more methods in class Page

* chore: fix typo in connection.spec.js (#7326)

recieved -> received

* chore: synchronize Bug 1710839: update comment about firefox preference remote.enabled (#7324)

* fix: added comments for methods in class page

* docs: add download location to the FAQ (#7339)

Co-authored-by: Mathias Bynens <mathias@qiwi.be>

* fix: added comments

* fix: comments added

* feat: add page.emulateCPUThrottling (#7343)

* fix: added comments

Co-authored-by: Jack Franklin <jacktfranklin@chromium.org>
Co-authored-by: Ikko Ashimine <eltociear@gmail.com>
Co-authored-by: Julian Descottes <julian.descottes@gmail.com>
Co-authored-by: Diego Fernandez <dfernandez79@users.noreply.github.com>
Co-authored-by: Mathias Bynens <mathias@qiwi.be>
Co-authored-by: Jan Scheffler <janscheffler@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants