Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make targetFilter synchronous #7203

Merged
merged 1 commit into from May 5, 2021
Merged

fix: make targetFilter synchronous #7203

merged 1 commit into from May 5, 2021

Conversation

jschfflr
Copy link
Contributor

@jschfflr jschfflr commented May 4, 2021 •
edited by mathiasbynens

This patch fixes #7192 the error discovered in mdn/yari#3694 where the await for the targetFilter resulted in a targetInfoChanged event being processed before the Target was created.

@google-cla google-cla bot added the cla: yes label May 4, 2021
@jschfflr jschfflr merged commit bcc85a0 into main May 5, 2021
@jschfflr jschfflr deleted the fix-target-filter-async branch May 5, 2021 07:50
@jschfflr jschfflr mentioned this pull request May 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@OrKoN OrKoN OrKoN approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jschfflr @mathiasbynens @OrKoN