Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll Chromium 92 #7102

Closed
mathiasbynens opened this issue Apr 19, 2021 · 5 comments
Closed

Roll Chromium 92 #7102

mathiasbynens opened this issue Apr 19, 2021 · 5 comments
Assignees

Comments

@mathiasbynens
Copy link
Member

Let's do this sometime after the feature freeze on May 7th. https://chromiumdash.appspot.com/schedule

@sadym-chromium sadym-chromium self-assigned this May 25, 2021
@sadym-chromium
Copy link
Collaborator

The latest available for all the platforms build is 884014.

@sadym-chromium
Copy link
Collaborator

sadym-chromium commented May 25, 2021

Bumping Chrome version to 884014 caused few problems:

  1. minimist package should be updated to at least version 1.2.3
  2. Some accessibility tests from accessibility.spec.ts are failing because of the CI 2830373
  3. Headful tests from headful.spec.ts are failing after merging this revisions.

@sadym-chromium
Copy link
Collaborator

sadym-chromium commented May 25, 2021

  1. Headful tests from headful.spec.ts are failing after merging this revisions.

Way to reproduce manually:

  1. Mark test only 'OOPIF: should expose events within OOPIFs'.
  2. Run test using DEBUG=* npm run unit.
  3. Verify in puppeteer:launcher there is a param --host-rules="MAP oopifdomain 127.0.0.1".
  4. Test fails here! On the open page, verify the frame with url http://oopifdomain:8907/one-style.html is not load.
  5. Try to manually launch browser with params from the logged puppeteer:launcher.
  6. Open http://oopifdomain:8907/one-style.html and verify the frame is load.

@sadym-chromium
Copy link
Collaborator

To ease bisecting, #7271 created.

@jschfflr jschfflr self-assigned this May 26, 2021
@jschfflr
Copy link
Contributor

This landed in #7288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants