feat(chromium): roll Chromium to r856583 #6927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corresponds to Chromium 90.0.4427.0
|
LGTM, but please mention the specific CL you're doing this for in the commit message so that it's clear why we're doing this roll. |
mathiasbynens
approved these changes
Feb 26, 2021
This corresponds to Chromium 90.0.4427.0 This roll includes: - Add sourceScheme, sourcePort, and sameParty to DevTools backend (https://crbug.com/1170548, https://crbug.com/1142606)
|
Looks like we'll need to update some test expectations as well? |
|
Yes, updated the tests. I need a private CDP API to be included for our contrast tests but there should be no public API changes except for one related to cookies. |
I figured :) What I meant is: please link to that upstream CL in the commit message, so the motivation for this roll is clear. Thanks! |
mathiasbynens
approved these changes
Feb 26, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corresponds to Chromium 90.0.4427.0 to include latest CDP changes (e.g, Audits.checkContrast).
This roll includes: