Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): page.pdf format using a4 #6890

Merged
merged 2 commits into from Feb 18, 2021
Merged

Conversation

ycjcl868
Copy link
Contributor

format property of the page.pdf method was a4 not A4.

ref: PaperFormat type.

image

`format` property of the `page.pdf` method was `a4` not `A4`.

ref: `PaperFormat` type
@google-cla
Copy link

google-cla bot commented Feb 16, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Feb 16, 2021
@mathiasbynens
Copy link
Member

Thanks for the patch! Once you accept the CLA, we can merge this. Thanks!

@ycjcl868
Copy link
Contributor Author

Thanks for the patch! Once you accept the CLA, we can merge this. Thanks!

Thanks!

@google-cla
Copy link

google-cla bot commented Feb 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mathiasbynens
Copy link
Member

@ycjcl868 Did you read the message above, about accepting the CLA? We cannot merge this until you do that.

@ycjcl868
Copy link
Contributor Author

@googlebot I signed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants