fix: add favicon test asset #6868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for adding the favicon! Please note that at least the above mentioned test will now pass in Firefox. I would expect that others might also pass. So |
The favicon was taken from https://github.com/mathiasbynens/small. Issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1682076
mathiasbynens
force-pushed
the
favicon
branch
from
46059d2
to
28172ee
Compare
mathiasbynens
commented
Feb 11, 2021
| @@ -29,8 +30,9 @@ | |||
| <button id=btn9>9</button> | |||
| <button id=btn10>10</button> | |||
| <script> | |||
| window.addEventListener('DOMContentLoaded', () => { | |||
There was a problem hiding this comment.
I wasn't around when this test was created, but I imagine it was written this way assuming the favicon warning would be logged before DOMContentLoaded. Now that we have a favicon, we no longer need to try and avoid the error message.
|
@whimboo Done! Please mark review+ through GitHub's UI once everything looks okay. |
whimboo
approved these changes
Feb 11, 2021
jackfranklin
approved these changes
Feb 11, 2021
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 13, 2021
…mote-protocol-reviewers,jdescottes Temporarily add a favicon to fix Puppeteer tests relying on a proper set of console log messages. It's the same favicon as used in puppeteer/puppeteer#6868 which will land post Puppeteer 7.0.4. Differential Revision: https://phabricator.services.mozilla.com/D104809
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Feb 16, 2021
…mote-protocol-reviewers,jdescottes Temporarily add a favicon to fix Puppeteer tests relying on a proper set of console log messages. It's the same favicon as used in puppeteer/puppeteer#6868 which will land post Puppeteer 7.0.4. Differential Revision: https://phabricator.services.mozilla.com/D104809 UltraBlame original commit: 045d91aa8b2f2921d8bfd0173a8e68c7a3b65cdb
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Feb 16, 2021
…mote-protocol-reviewers,jdescottes Temporarily add a favicon to fix Puppeteer tests relying on a proper set of console log messages. It's the same favicon as used in puppeteer/puppeteer#6868 which will land post Puppeteer 7.0.4. Differential Revision: https://phabricator.services.mozilla.com/D104809 UltraBlame original commit: 045d91aa8b2f2921d8bfd0173a8e68c7a3b65cdb
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Feb 16, 2021
…mote-protocol-reviewers,jdescottes Temporarily add a favicon to fix Puppeteer tests relying on a proper set of console log messages. It's the same favicon as used in puppeteer/puppeteer#6868 which will land post Puppeteer 7.0.4. Differential Revision: https://phabricator.services.mozilla.com/D104809 UltraBlame original commit: 045d91aa8b2f2921d8bfd0173a8e68c7a3b65cdb
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The favicon was taken from https://github.com/mathiasbynens/small.
Issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1682076