Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(page): add color-gamut support to Page.emulateMediaFeatures #6857

Merged
merged 3 commits into from Feb 11, 2021

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Feb 10, 2021

The change updates the validation function to allow color-gamut media
features and updates the documentation.

Issues: #6761

The change updates the validation function to allow color-gamut media
features and updates the documentation.

Issues: #6761
@google-cla
Copy link

google-cla bot commented Feb 10, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Feb 10, 2021
@OrKoN
Copy link
Collaborator Author

OrKoN commented Feb 10, 2021

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Feb 10, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

src/common/Page.ts Outdated Show resolved Hide resolved
docs/api.md Outdated Show resolved Hide resolved
docs/api.md Outdated Show resolved Hide resolved
The change updates the validation function to allow color-gamut media
features and updates the documentation.

Issues: #6761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants