fix(domworld): reset bindings when context changes (#6766) #6836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasbynens
approved these changes
Feb 8, 2021
| @@ -115,6 +115,7 @@ export class DOMWorld { | |||
|
|
|||
| async _setContext(context?: ExecutionContext): Promise<void> { | |||
| if (context) { | |||
| this._ctxBindings = new Set(); | |||
There was a problem hiding this comment.
Suggested change
| this._ctxBindings = new Set(); | |
| this._ctxBindings.clear(); |
| it('should persist query handler bindings across navigations', async () => { | ||
| const { page, server } = getTestState(); | ||
|
|
||
| // Reset page but make sure that execution context ids start with 1. |
There was a problem hiding this comment.
This comment confuses me. How do you assert the ids?
There was a problem hiding this comment.
I don't know how how the execution context ids are generated. But it seems like navigating within one origin results in incrementing ids while navigating across origins resets the ids to 1 again. That's why I added the two navigations there.
The previous test just checked by reloading the page which did not reset the ids and therefor did not uncover this edge case.
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.