Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0.1] No .d.ts for puppeteer-core #6820

Closed
thomassuckow opened this issue Feb 4, 2021 · 6 comments
Closed

[7.0.1] No .d.ts for puppeteer-core #6820

thomassuckow opened this issue Feb 4, 2021 · 6 comments
Assignees

Comments

@thomassuckow
Copy link

Steps to reproduce

Tell us about your environment:

  • Puppeteer version: 7.0.1
  • Platform / OS version: Windows 10
  • Node.js version: 15.0.1

What steps will reproduce the problem?

Install puppeteer-core and attempt to use it from typescript

What is the expected result?

It works

What happens instead?

TS7016: Could not find a declaration file for module 'puppeteer-core'. '[...]\puppeteer-core\cjs-entry-core.js' implicitly has an 'any' type.

It appears that while cjs-entry.js has a matching cjs-entry.d.ts, cjs-entry-core.js does not.

@mathiasbynens
Copy link
Member

Jack, could you PTAL?

@danielrentz
Copy link

Same for me, just tried to update from 5.5 to 7.0.1, and import { ... } from "puppeteer" stopped working.

How is that supposed to work? README still says to use the @types/puppeteer package, but that does not work either.

@thomassuckow
Copy link
Author

@danielrentz You are probably more interested in #6816 for type issues. This is specifically regarding puppeteer-core instead of puppeteer

@danielrentz
Copy link

Right, thanks for the pointer!

@thomassuckow
Copy link
Author

#6837 should resolve this once merged/released

@thomassuckow
Copy link
Author

Fixed in 7.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants