Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): mark v7.0.0 #6804

Merged
merged 1 commit into from
Feb 3, 2021
Merged

chore(release): mark v7.0.0 #6804

merged 1 commit into from
Feb 3, 2021

Conversation

jschfflr
Copy link
Contributor

@jschfflr jschfflr commented Feb 2, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Feb 2, 2021
mathiasbynens
mathiasbynens approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's wait until Maksim's change landed

sadym-chromium
sadym-chromium reviewed Feb 3, 2021
View reviewed changes
CHANGELOG.md

### ⚠ BREAKING CHANGES

* **chromium:** - `page.screenshot` cuts screenshot content by the ViewPort size, not ViewPort position.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **chromium:** - `page.screenshot` cuts screenshot content by the ViewPort size, not ViewPort position.
* **chromium:** - `page.screenshot` makes a screenshot with the clip dimensions, not cutting it by the ViewPort size.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog is automatically populated based on the commit messages. If we make changes now they will be overwritten later.

@sadym-chromium
Copy link
Collaborator

#6805 is merged. I added the suggestion to update the CHANGELOG.md. Despite that you are good to go.

LGTM

@sadym-chromium
Copy link
Collaborator

The failing test is removed in the #6805 . Rebase will fix the CI.

@jschfflr
Copy link
Contributor Author

jschfflr commented Feb 3, 2021

@sadym-chromium Does the cl look good to you now?

@jschfflr jschfflr merged commit edd8bcc into main Feb 3, 2021
@jschfflr jschfflr deleted the npm-release branch February 3, 2021 15:33
@limonte
Copy link

limonte commented Feb 3, 2021

Two major releases in two days, interesting approach.

@sadym-chromium
Copy link
Collaborator

We released Puppeteer v6.0.0 with Chromium 89 and v7.0.0 with Chromium 90. Each of them had breaking changes, that's why major version bump needed in both cases.

@limonte
Copy link

limonte commented Feb 3, 2021

We released Puppeteer v6.0.0 with Chromium 89 and v7.0.0 with Chromium 90. Each of them had breaking changes, that's why major version bump needed in both cases.

Got it, thanks for the clarification!

@limonte limonte mentioned this pull request Feb 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@sadym-chromium sadym-chromium sadym-chromium approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jschfflr @sadym-chromium @limonte @mathiasbynens