Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chromium): roll Chromium to r848005 #6801

Merged
merged 13 commits into from
Feb 2, 2021
Merged

feat(chromium): roll Chromium to r848005 #6801

merged 13 commits into from
Feb 2, 2021

Conversation

sadym-chromium
Copy link
Collaborator

This corresponds to Chromium 90.0.4403.0
This roll includes:

  • Cut screenshot by ViewPort size, not position (crrev.com/c/2643792)

BREAKING CHANGE:

  • page.screenshot cuts screenshot content by the ViewPort size, not ViewPort position.

@mathiasbynens
Copy link
Member

The images in this patch are much larger than the current versions:

Please compress them using ImageOptim or Squoosh.

LGTM otherwise

@sadym-chromium
Copy link
Collaborator Author

Compressed all 4 images, both new and old.

@sadym-chromium sadym-chromium marked this pull request as ready for review February 2, 2021 14:51
sadym-chromium and others added 3 commits February 2, 2021 16:24
This corresponds to Chromium 90.0.4403.0
This roll includes:
- Cut screenshot by ViewPort size, not position (crrev.com/c/2643792)

BREAKING CHANGE:
- `page.screenshot` cuts screenshot content by the ViewPort size, not ViewPort position.
@sadym-chromium sadym-chromium changed the title feat(chromium): roll Chromium to r 848005 feat(chromium): roll Chromium to r848005 Feb 2, 2021
@sadym-chromium sadym-chromium merged commit 890d5c2 into main Feb 2, 2021
@sadym-chromium sadym-chromium deleted the chrome_90 branch February 2, 2021 16:24
@puppeteer puppeteer deleted a comment from ralic Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants