chore(release): mark v6.0.0 #6800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ### ⚠ BREAKING CHANGES | ||
|
|
||
| * **chromium:** The built-in `aria/` selector query handler doesn’t return ignored elements anymore. |
There was a problem hiding this comment.
FYI @jackfranklin, re: our discussion from yesterday, in the future let's use the suggested Conventional Commits format to mark breaking changes:
BREAKING CHANGE: Foo bar baz…
That way it automatically appears in the changelog, like this line right here. I’ll try to keep an eye out for this during reviews as well, this is all new for me too :)
mathiasbynens
approved these changes
Feb 2, 2021
| @@ -17,7 +17,7 @@ | |||
| const versionsPerRelease = new Map([ | |||
| // This is a mapping from Chromium version => Puppeteer version. | |||
| // In Chromium roll patches, use 'NEXT' for the Puppeteer version. | |||
| ['89.0.4389.0', 'NEXT'], | |||
| ['89.0.4389.0', '6.0.0'], | |||
There was a problem hiding this comment.
In hindsight, this should have been 'v6.0.0' (the v is missing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.