Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use GitHub Actions to run unit tests on Windows and macOS #6782

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

mathiasbynens
Copy link
Member

Similar to our earlier Travis CI setup, we continue to run exhaustive checks on Linux, while also verifying the build + unit tests still work on other platforms.

Issue: #6726

Similar to our earlier Travis CI setup, we continue to run exhaustive checks on Linux, while also verifying the build + unit tests still work on other platforms.

Issue: #6726
Copy link
Contributor

@jschfflr jschfflr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % question.
Is there also maybe a way to define the common steps just once?

.github/workflows/main.yml Show resolved Hide resolved
@mathiasbynens
Copy link
Member Author

mathiasbynens commented Jan 26, 2021

Is there also maybe a way to define the common steps just once?

I initially tried doing that with needs: but it got a little unwieldy pretty fast. IMHO this is a case where it's more readable/maintainable to have a small amount of duplication.

@jschfflr
Copy link
Contributor

Sounds good, thanks!

@mathiasbynens
Copy link
Member Author

Maksim, could you also PTAL?

@sadym-chromium
Copy link
Collaborator

Is there also maybe a way to define the common steps just once?

I initially tried doing that with needs: but it got a little unwieldy pretty fast. IMHO this is a case where it's more readable/maintainable to have a small amount of duplication.

I have the same concern about having lots of copy-pasted code. But if the needs implementation is even more bulky, let's stick to this one for now.

@sadym-chromium
Copy link
Collaborator

sadym-chromium commented Jan 27, 2021

Do we need to add those jobs somewhere, or they all of them run automatically in workflows?

@mathiasbynens
Copy link
Member Author

Do we need to add those jobs somewhere, or they all of them run automatically in workflows?

They're all run automatically.

Copy link
Collaborator

@sadym-chromium sadym-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathiasbynens mathiasbynens merged commit c49d109 into main Jan 27, 2021
@mathiasbynens mathiasbynens deleted the ci-actions-os branch January 27, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants