-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): use GitHub Actions to run unit tests on Windows and macOS #6782
Conversation
Similar to our earlier Travis CI setup, we continue to run exhaustive checks on Linux, while also verifying the build + unit tests still work on other platforms. Issue: #6726
c702667
to
66d30d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % question.
Is there also maybe a way to define the common steps just once?
I initially tried doing that with |
Sounds good, thanks! |
Maksim, could you also PTAL? |
I have the same concern about having lots of copy-pasted code. But if the |
Do we need to add those jobs somewhere, or they all of them run automatically in workflows? |
They're all run automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Similar to our earlier Travis CI setup, we continue to run exhaustive checks on Linux, while also verifying the build + unit tests still work on other platforms.
Issue: #6726