Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship Puppeteer as JavaScript modules #6753

Closed
mathiasbynens opened this issue Jan 15, 2021 · 8 comments 路 Fixed by #7964
Closed

Ship Puppeteer as JavaScript modules #6753

mathiasbynens opened this issue Jan 15, 2021 · 8 comments 路 Fixed by #7964
Assignees

Comments

@mathiasbynens
Copy link
Member

mathiasbynens commented Jan 15, 2021

As Jack points out in https://twitter.com/Jack_Franklin/status/1349780548848390144, once even the oldest maintenance LTS version of Node.js supports JavaScript modules, we can ship Puppeteer as pure JavaScript modules.

馃コ

https://2ality.com/2021/06/typescript-esm-nodejs.html

mathiasbynens added a commit that referenced this issue May 3, 2021
This is a prerequisite for shipping Puppeteer as JavaScript modules.

Issue: #6753

BREAKING CHANGE: Node.js 10 is no longer supported.
mathiasbynens added a commit that referenced this issue May 12, 2021
This is a prerequisite for shipping Puppeteer as JavaScript modules.

Issue: #6753

BREAKING CHANGE: Node.js 10 is no longer supported.
mathiasbynens added a commit that referenced this issue May 17, 2021
This is a prerequisite for shipping Puppeteer as JavaScript modules.

Issue: #6753

BREAKING CHANGE: Node.js 10 is no longer supported.
@mathiasbynens
Copy link
Member Author

We might want to wait for microsoft/TypeScript#45884 to make it into a TypeScript release.

@mathiasbynens
Copy link
Member Author

As a first step, of course we should ship modules (in a way that Node.js can directly consume) alongside CommonJS. Then in the future, we can consider moving to modules-only.

@mathiasbynens mathiasbynens changed the title Ship Puppeteer as JavaScript modules only Ship Puppeteer as JavaScript modules Feb 1, 2022
@OrKoN
Copy link
Collaborator

OrKoN commented Feb 1, 2022

As a first step, of course we should ship modules (in a way that Node.js can directly consume) alongside CommonJS. Then in the future, we can consider moving to modules-only.

any suggestions on how we do that?

@mathiasbynens
Copy link
Member Author

The link in my top post has some info.

@mathiasbynens
Copy link
Member Author

Also https://2ality.com/2019/10/hybrid-npm-packages.html

@mathiasbynens
Copy link
Member Author

@stale
Copy link

stale bot commented Jun 23, 2022

We're marking this issue as unconfirmed because it has not had recent activity and we weren't able to confirm it yet. It will be closed if no further activity occurs within the next 30 days.

@stale stale bot added the unconfirmed label Jun 23, 2022
@stale
Copy link

stale bot commented Jul 23, 2022

We are closing this issue. If the issue still persists in the latest version of Puppeteer, please reopen the issue and update the description. We will try our best to accomodate it!

@stale stale bot closed this as completed Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment