Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support promise as return value for page.waitForResponse predicate #6624

Merged
merged 3 commits into from
Nov 25, 2020
Merged

feat: support promise as return value for page.waitForResponse predicate #6624

merged 3 commits into from
Nov 25, 2020

Conversation

mickykebe
Copy link
Contributor

Fix #4323

Adaptation of #5008 with example code added to the docs.

@google-cla google-cla bot added the cla: yes label Nov 25, 2020
@mathiasbynens
Copy link
Member

mathiasbynens commented Nov 25, 2020 •
edited

Let's add

Co-authored-by: Joni <josalmi@google.com>

to the commit message, to credit the author of #5008 (@josalmi).

@mathiasbynens mathiasbynens merged commit b57f3fc into puppeteer:main Nov 25, 2020
@mathiasbynens mathiasbynens mentioned this pull request Nov 25, 2020
Closed
@Androbin Androbin mentioned this pull request May 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can waitForResponse take a promise instead of function or url?
2 participants
@mickykebe @mathiasbynens