chore: run unit tests on node 10.15 + fix fs.promises access #6550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We saw in #6548 that the `fs.promises` module was experimental in Node <10.17 and as such we introduced issues for users on 10.15. Until we can drop Node v10 (it's EOL is 30-04-20201 https://github.com/nodejs/Release#release-schedule) we should run our tests on an old Node 10 to avoid regressing in this area.
|
Note that I'm expecting the 10.15 CI run to fail, but hoping that I can then patch #6549 in and that will fix it. |
mathiasbynens
approved these changes
Oct 26, 2020
|
@mathiasbynens PTAL at the latest commit. I took the work in #6549 but extracted it into a helper function that we can use in the mean time. That, plus running tests on Node 10.15, should ensure we don't hit this again. |
jackfranklin
changed the title
mathiasbynens
approved these changes
Oct 26, 2020
jackfranklin
force-pushed
the
node-10-15
branch
from
377dd98
to
d1ffcbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw in #6548 that the
fs.promisesmodule was experimental in Node <10.17 and as such weintroduced issues for users on 10.15.
Until we can drop Node v10 (it's EOL is 30-04-20201
https://github.com/nodejs/Release#release-schedule) we should run our
tests on an old Node 10 to avoid regressing in this area.
Closes #6548 .